Skip to content

fix(ci): pass toolchain to dtolnay/rust-toolchain in the Rust Benchmarks jobs - #386

Merged
jdfalk merged 1 commit into
mainfrom
fix/ci-rust-toolchain-input
Nov 6, 2026
Merged

jdfalk merged 1 commit into
mainfrom
fix/ci-rust-toolchain-input

Conversation

@jdfalk

@jdfalk jdfalk commented Nov 6, 2026

Copy link
Copy Markdown
Collaborator

Why

CI Self Tests has failed on every run since 2026-02-10, and Performance Monitoring fails every day. In both, the only failing job is Rust Benchmarks:

'toolchain' is a required input

dtolnay/rust-toolchain@683b588c… is a SHA on the action's master branch. Master has no default toolchain; only the named branches like stable do. The pin comment said # stable, which hid this.

Change

  • ci-tests.yml and performance-monitoring.yml: both Rust Benchmarks jobs now pass toolchain: stable.
  • All four workflows that use the action: the pin comment now says # master. pr-automation.yml and reusable-ci.yml already passed toolchain, so for them only the comment changes.
  • Headers bumped; changelog fragment added; GUID index regenerated by the hook.

Test plan

  • CI Self Tests is green on this PR, or on the dispatch after merge.
  • Performance Monitoring is green on its next run.

🤖 Generated with Claude Code

https://claude.ai/code/session_011To9HQJLrCH6wYa5WCpw3L

…rks jobs

The action is pinned to a master-branch SHA, which has no default
toolchain, so both Rust Benchmarks jobs failed with "'toolchain' is a
required input" and kept CI Self Tests and Performance Monitoring red
since February. Pass toolchain: stable, and label the pin # master in
all four workflows, which is what the SHA is.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011To9HQJLrCH6wYa5WCpw3L
@github-actions github-actions Bot added size/M github-actions GitHub Actions related work automation Automation scripts and tools type:documentation Improvements or additions to documentation type:testing Testing related work module:config Configuration management workflow:automation Automation and tooling workflow:github-actions GitHub Actions workflows workflow:ci-cd Continuous integration and deployment labels Nov 6, 2026
@jdfalk
jdfalk merged commit c8c3576 into main Nov 6, 2026
61 checks passed
@jdfalk
jdfalk deleted the fix/ci-rust-toolchain-input branch November 6, 2026 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automation Automation scripts and tools github-actions GitHub Actions related work module:config Configuration management size/M type:documentation Improvements or additions to documentation type:testing Testing related work workflow:automation Automation and tooling workflow:ci-cd Continuous integration and deployment workflow:github-actions GitHub Actions workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant